Repository navigation
fix: pagination fix for `--fields and `--all-pages combination - #9
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes pagination when --fields is combined with --all-pages by ensuring the internal pagination field (serpapi_pagination.next) is preserved in the server-side projection and by reapplying the restrictor on subsequent page requests.
Changes:
- Injects
serpapi_pagination.nextintojson_restrictorduring--all-pagesruns and reapplies it when followingserpapi_pagination.nextURLs. - Adds unit tests for the restrictor helper and for carrying
json_restrictorthrough pagination URLs. - Adds an end-to-end regression test for
--fields+--all-pagesensuring multi-page merging while keeping output limited to requested fields.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pkg/cmd/search.go |
Preserves pagination metadata under --fields and reapplies json_restrictor when following next URLs. |
pkg/cmd/search_test.go |
Adds coverage for the new restrictor behavior and updated parseNextParams signature. |
tests/e2e_test.go |
Adds a live regression test for --fields + --all-pages output shape and multi-page merging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+156
to
+160
| if restrictor == "" { | ||
| return "" | ||
| } | ||
| return restrictor + "," + paginationRestrictorPath | ||
| } |
Member
Author
There was a problem hiding this comment.
I tested this with live API calls and confirmed that duplicate and overlapping JSON Restrictor paths do not cause errors. Our API returns the requested union of fields.
Comment on lines
+176
to
+179
| out, err := cmd.Output() | ||
| if err != nil { | ||
| t.Fatalf("search all pages with fields failed: %v", err) | ||
| } |
ilyazub
added a commit
that referenced
this pull request
Oct 13, 2026
v0.2.3 shipped on 2026-03-31; #7, #9, #15 and #17 merged after it and none reached users, because a release waited for someone to push a tag. Now, after both test legs and the live e2e pass on main, the tag job tags the commit with the next version and calls release.yml: a patch, or what the PR's release:minor or release:major label asks for. A release:skip label, or a merge where nothing that ships changed since the latest release, releases nothing. Outside pull requests a skipped live test fails CI, a published tag is never reused, a commit older than the latest release is never tagged, and runs on main go one at a time. A Release preview check tells each PR what merging releases. Dry run on this history: this branch with release:minor gives v0.3.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
--fieldspreventing--all-pagesfrom fetching subsequent pages by preserving the internal pagination restrictor across requests.Fixes #8